Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] #3974: Add subcommand into iroha_client_cli to transfer domains #4031

Merged
merged 2 commits into from
Nov 22, 2023
Merged

[feature] #3974: Add subcommand into iroha_client_cli to transfer domains #4031

merged 2 commits into from
Nov 22, 2023

Conversation

pesterev
Copy link
Contributor

@pesterev pesterev commented Nov 3, 2023 •
edited
Loading

Description

This pull request adds command to transfer domains between accounts into iroha_client_cli.

Linked issue

Closes one of subtasks from #3974

Benefits

Extends the functionality of iroha_client_cli.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 3, 2023
@coveralls
Copy link

coveralls commented Nov 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6956741032

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 16 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7007 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.1%) to 56.289%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client_cli/src/main.rs 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.1%
Covered Lines: 23015
Relevant Lines: 40887
💛 - Coveralls

Erigara
Erigara suggested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's cover this functionality in python client tests?

client_cli/src/main.rs Show resolved Hide resolved
@pesterev pesterev force-pushed the client-cli-transfer-domain branch from 3360119 to b7f6835 Compare November 3, 2023 14:33
@Arjentix Arjentix self-assigned this Nov 3, 2023
Arjentix
Arjentix reviewed Nov 3, 2023
View reviewed changes
client_cli/src/main.rs Outdated Show resolved Hide resolved
client_cli/src/main.rs Outdated Show resolved Hide resolved
@Arjentix Arjentix added the Enhancement New feature or request label Nov 3, 2023
@pesterev pesterev force-pushed the client-cli-transfer-domain branch 2 times, most recently from 9ac079c to 153c4c6 Compare November 7, 2023 07:15
@pesterev pesterev requested review from Erigara and Arjentix November 7, 2023 07:16
0x009922
0x009922 previously approved these changes Nov 13, 2023
View reviewed changes
@pesterev pesterev force-pushed the client-cli-transfer-domain branch 2 times, most recently from 35d1157 to 9bdaa26 Compare November 14, 2023 07:56
@pesterev pesterev force-pushed the client-cli-transfer-domain branch from 9bdaa26 to 2c539ab Compare November 14, 2023 12:09
@pesterev pesterev requested a review from 0x009922 November 14, 2023 13:14
@AlexStroke AlexStroke force-pushed the client-cli-transfer-domain branch 2 times, most recently from 882d730 to 9423953 Compare November 16, 2023 14:26
@pesterev pesterev force-pushed the client-cli-transfer-domain branch from 9423953 to 40544b6 Compare November 22, 2023 10:07
@pesterev pesterev force-pushed the client-cli-transfer-domain branch from 40544b6 to 5a182ec Compare November 22, 2023 11:35
pesterev and others added 2 commits November 22, 2023 15:36
@pesterev pesterev force-pushed the client-cli-transfer-domain branch from 5a182ec to 53cb473 Compare November 22, 2023 11:36
@pesterev pesterev merged commit 6d75fe9 into hyperledger-iroha:iroha2-dev Nov 22, 2023
1 check passed
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@Arjentix Arjentix Arjentix approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@mversic mversic Awaiting requested review from mversic

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@DCNick3 DCNick3 Awaiting requested review from DCNick3

@0x009922 0x009922 Awaiting requested review from 0x009922

Assignees

@pesterev pesterev

@Arjentix Arjentix

@Erigara Erigara

@alexstroke1 alexstroke1

Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pesterev @coveralls @Arjentix @Erigara @0x009922 @AlexStroke @alexstroke1